Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error processing empty client nonce in digest auth #18

Closed
endragor opened this issue Nov 24, 2012 · 1 comment
Closed

Error processing empty client nonce in digest auth #18

endragor opened this issue Nov 24, 2012 · 1 comment
Assignees

Comments

@endragor
Copy link

There is an error in Digest.prototype.parseAuthHeader:

var tokens = searchHeader.match(/(\w+)="([^"]+)"/g);

means that auth parameter values can't be empty but client actually might send empty cnonce which will result in undefined (instead of being empty) cnonce variable on server side.

@ghost ghost assigned gevorg Nov 24, 2012
@gevorg
Copy link
Owner

gevorg commented Nov 24, 2012

Issue is fixed and pushed with 1.2.3 version. I published it to NPM as well. Thanks, Gevorg.

@gevorg gevorg closed this as completed Nov 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants