Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test combination of features in regression_test.sh #27

Closed
jacobmiller22 opened this issue Jan 15, 2023 · 4 comments
Closed

Test combination of features in regression_test.sh #27

jacobmiller22 opened this issue Jan 15, 2023 · 4 comments

Comments

@jacobmiller22
Copy link
Contributor

Should we be testing all possible combinations of feature flags in the regression_test.sh script (Or at least somewhere)? I don't think at the moment there are any feature attributes that depend on more than one feature, but it seems as if it should be tested before the release at the very least. The downside of all possible combinations is that these tests will take considerably longer to test. At the very least the urispec feature needs to be added to the regression_test.sh. I will make a PR to go the route desired.

@gftea
Copy link
Owner

gftea commented Jan 15, 2023

yes, urispec is currently missing, also in github workflows, both need to be updated

@jacobmiller22
Copy link
Contributor Author

jacobmiller22 commented Jan 15, 2023

Just for further clarification, you are on board with testing all combinations of feature flags?

@gftea
Copy link
Owner

gftea commented Jan 15, 2023

I think Due to the fact that all optional features are standalone(no inter dependencies) we only need test each feature plus all together . Do you see significant gains to test all combinations ? But we can improve CI by using cargo-hack which is good for testing combination easier

@jacobmiller22
Copy link
Contributor Author

I agree that its not needed given there are no interdependencies, but do you see that being likely in the future? Perhaps cargo-hack would be useful to have set up before a feature with interdependencies is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants