Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference resources in device operations #637

Closed
kvark opened this issue Mar 8, 2015 · 0 comments · Fixed by #639
Closed

Reference resources in device operations #637

kvark opened this issue Mar 8, 2015 · 0 comments · Fixed by #639

Comments

@kvark
Copy link
Member

kvark commented Mar 8, 2015

device::handle::Bare trait should not be needed. Every time the device needs to access a bare handle, it should do it via self.frame_handles.ref_something() method, thus making sure the resource lives up to the end of the frame.

This extends #633

@kvark kvark self-assigned this Mar 10, 2015
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
637: Wait for idle before destroying swapchains r=kvark a=kvark

Follow up to gfx-rs#636 
I was trying to address the D3D12 error in gfx-rs#3242
The debug messages complain about a resource being used by the queue while it's being destroyed. I thought forcing a wait there would help, but it does not. I think it's still a good change to land though.

In the meantime, I wonder if it considers the swapchain to be used because it's currently presented. Could be something else I'm missing here.

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant