Resource tracking and destruction #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
added
status: working
module: structure
status: blocked
and removed
status: working
labels
|
Nice! |
|
Looks good so far. |
| use alloc::arc::{strong_count, weak_count}; | ||
| use std::ops::Deref; | ||
| vector.retain(|v| { | ||
| strong_count(v) > 1 || weak_count(v) > 1 || { |
There was a problem hiding this comment.
can we just use an if? this is a bit to tricky.
let free = !(strong_count(v) > 1 || weak_count(v) > 1);
if free { fun(param, v.deref()); }
!free
This was referenced Mar 8, 2015
kvark
changed the title
|
Looks good. |
|
Is this still blocked? |
|
No, I forgot to change the issue status. It's all ready. Regards,
|
|
Ok, I'll merge! |
bvssvni
added a commit
that referenced
this pull request
Mar 8, 2015
Resource tracking and destruction
This was referenced Mar 8, 2015
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
633: Fix build status badge r=grovesNL a=Gordon-F fix gfx-rs#630 Co-authored-by: Igor Shaposhnik <Gordon-F@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements automatic management of the resources. Works just like RAII.
Closes #288, #617
User API changes:
factory.delete_something()any more!RendererandFactoryaccept all handles by reference to avoid cloningFactoryworks withRawBuffertype natively now instead ofBuffer<()>device.after_frame()afterglfw.swap_buffers()TODO:
handle::Manager)after_free()