Dynamic PSO states refactor #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note on enum -> Option conversions. At some point in the past, I suggested to use enums for cleaner semantics at the type level. Now it's more clear that type level clarity is less important here as just being straight and simple. Option gives you that, without sacrificing the type safety. |
grovesNL
approved these changes
Aug 8, 2019
| /// A generic struct holding the properties of two sides of a polygon. | ||
| #[derive(Clone, Copy, Debug, Default, Eq, Hash, PartialEq)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| pub struct Sided<T> { |
There was a problem hiding this comment.
Maybe just PolygonFaces or similar?
|
Ok, I don't think there is a lot of controversy about the PR, other than the "Sided" name :)
Bors r=grovesNL
… On Aug 8, 2019, at 08:13, Josh Groves ***@***.***> wrote:
@grovesNL approved this pull request.
In src/hal/src/pso/output_merger.rs:
> }
}
}
+/// A generic struct holding the properties of two sides of a polygon.
+#[derive(Clone, Copy, Debug, Default, Eq, Hash, PartialEq)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+pub struct Sided<T> {
Maybe just PolygonFaces or similar?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bors bot
added a commit
that referenced
this pull request
Aug 8, 2019
2944: Dynamic PSO states refactor r=grovesNL a=kvark Fixes #2905 PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2905
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code