Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More dynamic states #2905

Closed
kvark opened this issue Jul 17, 2019 · 1 comment · Fixed by #2944
Closed

More dynamic states #2905

kvark opened this issue Jul 17, 2019 · 1 comment · Fixed by #2944
Assignees
@kvark
Labels
backend: Vulkan client: request feature request from a known client difficulty: average status: ready for work type: feature value: high
Milestone
HAL 0.3 release

Comments

@kvark
Copy link
Member

kvark commented Jul 17, 2019

See gfx-rs/wgpu#248 (comment)

  • line width
  • stencil compare mask
  • stencil write mask
  • stencil ref
@kvark kvark added this to the HAL 0.3 release milestone Jul 17, 2019
@kvark kvark mentioned this issue Jul 17, 2019
Closed
@AlexEne AlexEne mentioned this issue Aug 7, 2019
Closed
@kvark kvark self-assigned this Aug 8, 2019
@kvark
Copy link
Member Author

kvark commented Aug 8, 2019

Actually, these are in the API. It's just that the Vulkan backend didn't respect them.
I figured out the semantics isn't the best: we are currently able to specify that, say, the front stencil face has a dynamic reference value, while the back face has a static one. This isn't valid in Vulkan...

@kvark kvark mentioned this issue Aug 8, 2019
Merged
4 tasks
bors bot added a commit that referenced this issue Aug 8, 2019
@bors @kvark
Merge #2944
bcfb6d7 
2944: Dynamic PSO states refactor r=grovesNL a=kvark

Fixes #2905
PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@bors bors bot closed this as completed in #2944 Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
backend: Vulkan client: request feature request from a known client difficulty: average status: ready for work type: feature value: high
Projects
None yet
Milestone
HAL 0.3 release
Development

Successfully merging a pull request may close this issue.

Dynamic PSO states refactor kvark/gfx
1 participant
@kvark