[0.3/dx12] split explicit external pass barrier access for depth attachments #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind expanding on why handling depth stencil attachments differently is required? |
kvark
requested changes
Sep 13, 2019
The access flags specified in an external barrier apply to the whole sub-pass, so it's a union of flags needed for depth and color and resolve etc. When we try to map them to D3D12 states, the conversion assumes the access flags to be required specifically, so it's confused and it's producing the wrong initial state. |
4 tasks
|
See #3014 . Please let me know if this works for you! |
bors bot
added a commit
that referenced
this pull request
Sep 14, 2019
3014: [0.3/dx12] rework resource state conversion, better external barriers r=msiglreith a=kvark Follow-up to #3010 that tries to address #3009 better. Replaces #3013 PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: dx12 - [ ] `rustfmt` run on changed code Contains 2 ideas: 1. we try to extract more information out of the image layouts, which is more robust 2. we are very selective in the external access dependencies, only taking ones that are related to where the attachment is used first or last. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot
added a commit
that referenced
this pull request
Sep 17, 2019
3014: [0.3/dx12] rework resource state conversion, better external barriers r=msiglreith a=kvark Follow-up to #3010 that tries to address #3009 better. Replaces #3013 Edit: this combines parts 2 and 3 of the big dx12 barrier refactor :) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: dx12 - [ ] `rustfmt` run on changed code Contains 2 ideas: 1. we try to extract more information out of the image layouts, which is more robust 2. we are very selective in the external access dependencies, only taking ones that are related to where the attachment is used first or last. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot
added a commit
that referenced
this pull request
Sep 17, 2019
3014: [0.3/dx12] rework resource state conversion, better external barriers r=msiglreith a=kvark Follow-up to #3010 that tries to address #3009 better. Replaces #3013 Edit: this combines parts 2 and 3 of the big dx12 barrier refactor :) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: dx12 - [ ] `rustfmt` run on changed code Contains 2 ideas: 1. we try to extract more information out of the image layouts, which is more robust 2. we are very selective in the external access dependencies, only taking ones that are related to where the attachment is used first or last. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
Closing in favor of #3014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #3010
Fixes #3009
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed codeHandle the case for depth access provided in the explicit external barriers separately.
Also set the
endin case ofRange { start: Sr::External, end: Sr::Pass(_) }since there is no guarantee that there is always aRange { start: Sr::Pass(_), end: Sr::External }for transitioning back the resources, at least Vulkan doesn't need it.cc @kvark