[0.5/dx12] essential fixes to depth views and command allocation #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
msiglreith
approved these changes
Aug 14, 2020
Fixes the following error: D3D12 ERROR: ID3D12Device::CreateShaderResourceView: The format (0x2d, D24_UNORM_S8_UINT) cannot be used with a ShaderResource view. [ STATE_CREATION ERROR gfx-rs#28: CREATESHADERRESOURCEVIEW_INVALIDFORMAT]
|
Thanks for the review! |
bors bot
added a commit
that referenced
this pull request
Aug 14, 2020
3330: [0.5/dx12] essential fixes to depth views and command allocation r=msiglreith a=kvark Fixes #2656 Tested on vange-rs and wgpu-rs examples With these fixes, we run wgpu-rs stuff without validation errors, and terminate successfully 馃帀 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2656
Tested on vange-rs and wgpu-rs examples
With these fixes, we run wgpu-rs stuff without validation errors, and terminate successfully 馃帀