This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Update with minBufferBindingSize #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
Jun 17, 2020
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 17, 2020
726: Basic support for minBufferBindingSize r=cwfitzgerald a=kvark **Connections** Has basic (partial) implementation of gpuweb/gpuweb#678 wgpu-rs update - gfx-rs/wgpu-rs#377 **Description** This change allows users to optionally specify the expected minimum binding size for buffers. We are then validating this against both the pipelines and bind groups. If it's not provided, we'll need to validate at draw time - this PR doesn't do this (focus on API changes first). It also moves out the `read_spirv`, since wgpu-types wasn't the right home for it ever. **Testing** Tested on wgpu-rs examples Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
bors r=cwfitzgerald |
bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
377: Update with minBufferBindingSize r=cwfitzgerald a=kvark Depends on gfx-rs/wgpu#726 Also reverts #373 : buffer bindings now have to include at least one element of an unsized struct portion, so they can't be zero-sized. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
Build failed: |
|
Updated the water example and fixed it to work on Metal. |
bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
377: Update with minBufferBindingSize r=cwfitzgerald a=kvark Depends on gfx-rs/wgpu#726 Also reverts #373 : buffer bindings now have to include at least one element of an unsized struct portion, so they can't be zero-sized. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
Build failed: |
|
web backend fixes |
|
Third times the charm :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gfx-rs/wgpu#726
Also reverts #373 : buffer bindings now have to include at least one element of an unsized struct portion, so they can't be zero-sized.