Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic stencil reference #248

Closed
msiglreith opened this issue Jul 17, 2019 · 4 comments
Closed

Dynamic stencil reference #248

msiglreith opened this issue Jul 17, 2019 · 4 comments
Labels
type: bug Something isn't working

Comments

@msiglreith
Copy link
Contributor

Setting stencil reference per command requires marking it as dynamic state in the graphics pipeline which at least the vulkan backend doesn't do atm

@msiglreith msiglreith added the type: bug Something isn't working label Jul 17, 2019
@kvark
Copy link
Member

kvark commented Jul 17, 2019

So this needs to be addressed in gfx-rs first, was missing from gfx-rs/gfx#1567 ?

@msiglreith
Copy link
Contributor Author

@kvark yes, it appears what's supported so far for the vulkan backend and hal is:
Viewport, Scissor, Blend Constants and Depth Bounds

Comparing with vkspecs what would be missing from core so far is: line width, depth bias, stencil compare mask, stencil write mask and stencil ref

@kvark
Copy link
Member

kvark commented Jul 17, 2019

btw, depth bias is there
Created gfx-rs/gfx#2905 for the rest

@kvark
Copy link
Member

kvark commented Aug 19, 2019

This is fixed by #282

@kvark kvark closed this as completed Aug 19, 2019
@ghost ghost mentioned this issue Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants