Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build, general queue group, shaders #3

Merged
merged 4 commits into from Sep 16, 2018
Merged

Fix build, general queue group, shaders #3

merged 4 commits into from Sep 16, 2018

Conversation

grovesNL
Copy link
Collaborator

@grovesNL grovesNL commented Sep 15, 2018 •
edited

  • Update to latest gfx-memory
  • Fix return value when backend is specified
  • Create general queue group (at least for now)
  • Create shader modules

@grovesNL grovesNL changed the title Fix build when backend is specified Fix build and general queue group Sep 15, 2018
@grovesNL grovesNL changed the title Fix build and general queue group Fix build, general queue group, shaders Sep 16, 2018
kvark
kvark approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
bors r+

@kvark kvark merged commit affe65d into gfx-rs:master Sep 16, 2018
@grovesNL grovesNL deleted the fix-build branch September 16, 2018 18:23
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this pull request Feb 23, 2020
@bors
Merge gfx-rs#3
cf5d589 
3: Rename hello_ examples to hello- (gfx-rs#2) r=kvark a=paulkernfeld



Co-authored-by: Paul Kernfeld <paulkernfeld@gmail.com>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
@bors
[rs] Merge gfx-rs#3
fdef638 
3: Rename hello_ examples to hello- (gfx-rs#2) r=kvark a=paulkernfeld



Co-authored-by: Paul Kernfeld <paulkernfeld@gmail.com>
victorvde pushed a commit to victorvde/wgpu that referenced this pull request Apr 23, 2023
@gents83
Merge pull request gfx-rs#3 from gfx-rs/master
a1b6b81 
Update outdated notice of GL being unsupported (gfx-rs#3638)
cwfitzgerald pushed a commit that referenced this pull request Oct 26, 2023
@bors @msiglreith
Merge #3
4097a10 
3: Add struct for descriptor binding r=grovesNL a=msiglreith

A bit more safety for API users to pass the correct values.

Co-authored-by: msiglreith <m.siglreith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grovesNL @kvark