Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error instead of panicking when canvas context is unavailable #3052

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Return an error instead of panicking when canvas context is unavailable #3052

merged 2 commits into from
Dec 1, 2022

Commits on Dec 1, 2022

  1. Low-level error handling in canvas context creation (for WebGPU and W… 

    …ebGL 2).

Part of fixing gfx-rs#3017. This commit changes the handling of `web_sys`
errors and nulls from `expect()` to returning `Err`, but it doesn't
actually affect the public API — that will be done in the next commit.
    @kpreid
    kpreid committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    b265540 View commit details
    Browse the repository at this point in the history

  2. Breaking: Change type of create_surface() functions to expose canva… 

    …s errors.

Part of fixing gfx-rs#3017.
    @kpreid
    kpreid committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    c28eab2 View commit details
    Browse the repository at this point in the history