Fixed: enabling PARTIALLY_BOUND_BINDING_ARRAY does not get enabled on vulkan backend
#3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Jun 5, 2023
|
Poke from triage |
`VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT` on the vulkan backend + added `partially_bounded_array` test
…ed_arrays` to `tests/tests/partially_bounded_arrays/`
|
Pokes back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
resolves 3522.
Description
Fixed: enabling
PARTIALLY_BOUND_BINDING_ARRAYdoes not enableVK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BITon the Vulkan backend, I've also addedpartially_bounded_arraytest.Testing
run the
partially_bounded_arraytest.