refactor: use built-in {integer}::power_of_two methods
#5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
push-rvoskywuwwty
branch
2 times, most recently
from
aed5a61
to
af3f41d
Compare
ErichDonGubler
force-pushed
the
push-rvoskywuwwty
branch
from
af3f41d
to
122e406
Compare
This is a win overall because it can use an implementation in `std`, _and_ can often compile to an intrinsic to save instructions. Upstream implementation: <https://github.com/rust-lang/rust/blob/9f877c9cd2c3f8f2f64df1e0c1804ad0682416d0/library/core/src/num/nonzero.rs#L1219>
ErichDonGubler
force-pushed
the
push-rvoskywuwwty
branch
from
122e406
to
1b43c8f
Compare
cwfitzgerald
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
N/A
Description
This is a win overall because it can use an implementation in
std,and can often compile to an intrinsic to save instructions.
Upstream implementation:
https://github.com/rust-lang/rust/blob/9f877c9cd2c3f8f2f64df1e0c1804ad0682416d0/library/core/src/num/nonzero.rs#L1219
Testing
I think CI is persuasive enough here.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toI don't think this is necessary.CHANGELOG.md. See simple instructions inside file.