Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding single quotes around Object, ArrayRef and HashRef barewords #68

Merged
merged 1 commit into from
Dec 25, 2016

Conversation

clalansingh
Copy link

Hi there,

I've discovered that two tests have been failing which can be solved by adding single quotes to barewords. The failed tests are:

t/020_attributes/014_misc_attribute_coerce_lazy.t .............. Bareword found where operator expected at t/020_attributes/014_misc_attribute_coerce_lazy.t line 31, near "coerce"
        (Missing semicolon on previous line?)
Bareword found where operator expected at t/020_attributes/014_misc_attribute_coerce_lazy.t line 37, near "has"
        (Missing semicolon on previous line?)
String found where operator expected at t/020_attributes/014_misc_attribute_coerce_lazy.t line 37, near "has 'headers'"
        (Do you need to predeclare has?)
"my" variable $r masks earlier declaration in same statement at t/020_attributes/014_misc_attribute_coerce_lazy.t line 47.
syntax error at t/020_attributes/014_misc_attribute_coerce_lazy.t line 31, near "coerce "
Execution of t/020_attributes/014_misc_attribute_coerce_lazy.t aborted due to compilation errors.
t/020_attributes/014_misc_attribute_coerce_lazy.t .............. Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
t/040_type_constraints/005_util_type_coercion.t ................ 1/8 Semicolon seems to be missing at t/040_type_constraints/005_util_type_coercion.t line 27.
syntax error at t/040_type_constraints/005_util_type_coercion.t line 28, near "coerce "
Execution of t/040_type_constraints/005_util_type_coercion.t aborted due to compilation errors.
# Looks like your test exited with 255 just after 1.
t/040_type_constraints/005_util_type_coercion.t ................ Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 7/8 subtests 

With the summary as follows:

Test Summary Report
-------------------
t/020_attributes/014_misc_attribute_coerce_lazy.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/040_type_constraints/005_util_type_coercion.t              (Wstat: 65280 Tests: 1 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 1.
t/040_type_constraints/018_custom_parameterized_types.t      (Wstat: 0 Tests: 28 Failed: 0)
  TODO passed:   13, 19-20, 22
Files=301, Tests=6105, 53 wallclock secs ( 1.45 usr  0.54 sys + 21.48 cusr  5.17 csys = 28.64 CPU)
Result: FAIL

After fixing the barewords in my pull request, all tests pass:

Test Summary Report
-------------------
t/040_type_constraints/018_custom_parameterized_types.t      (Wstat: 0 Tests: 28 Failed: 0)
  TODO passed:   13, 19-20, 22
t/040_type_constraints/021_maybe_type_constraint.t           (Wstat: 0 Tests: 36 Failed: 0)
  TODO passed:   27
Files=301, Tests=6114, 46 wallclock secs ( 1.71 usr  0.41 sys + 24.36 cusr  5.30 csys = 31.78 CPU)
Result: PASS

Thanks,
Chris

@syohex
Copy link
Collaborator

syohex commented Dec 24, 2016

Looks good. However I cannot reproduce this issue. Which perl version did you use ?

@clalansingh
Copy link
Author

clalansingh commented Dec 24, 2016 via email

@syohex syohex merged commit fe30e0d into xslate:master Dec 25, 2016
@syohex
Copy link
Collaborator

syohex commented Dec 25, 2016

Thanks for information. I confirmed this bug is reproduced.

@clalansingh
Copy link
Author

clalansingh commented Dec 25, 2016 via email

@clalansingh
Copy link
Author

clalansingh commented Jan 3, 2017 via email

syohex added a commit that referenced this pull request Jan 6, 2017
Changelog diff is:

diff --git a/Changes b/Changes
index a8aebef..c50ca85 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
 Revision history for Mouse

 {{$NEXT}}
+
+v2.4.6 2017-01-06T06:51:15Z
     - Fix test for older Perls (#68)
     - Define macros for older Visual Studio compiler(#66)
@syohex
Copy link
Collaborator

syohex commented Jan 6, 2017

Released

syohex added a commit that referenced this pull request Jan 14, 2017
Changelog diff is:

diff --git a/Changes b/Changes
index c50ca85..6565eeb 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,11 @@ Revision history for Mouse

 {{$NEXT}}

+v2.4.7 2017-01-14T13:46:04Z
+    - Workaround for issue #64(#67)
+      In some case stack is corrupted at more than 23 attributes.
+      This change may makes a bit slow in that case.
+
 v2.4.6 2017-01-06T06:51:15Z
     - Fix test for older Perls (#68)
     - Define macros for older Visual Studio compiler(#66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants