-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding single quotes around Object, ArrayRef and HashRef barewords #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good. However I cannot reproduce this issue. Which perl version did you use ? |
This was on Perl 5.18.2 on Debian 8.
…On 10:38PM, Fri, Dec 23, 2016 Syohei YOSHIDA ***@***.***> wrote:
Looks good. However I cannot reproduce this issue. Which perl version did
you use ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#68 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAk8LviFy2WB5HmkkeGxhT4FndESGprkks5rLJPDgaJpZM4LU8kU>
.
|
Thanks for information. I confirmed this bug is reproduced. |
Great, thanks very much.
…On 12:27AM, Sun, Dec 25, 2016 Syohei YOSHIDA ***@***.***> wrote:
Thanks for information. I confirmed this bug is reproduced.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#68 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAk8Lm480XIybFYMUs5rnqUdR9sSXZZvks5rLf7KgaJpZM4LU8kU>
.
|
Hi again,
I was wondering about when changes in the github repo are pushed to CPAN,
as the current tag was created in August of 2015. Thanks!
On Sun, Dec 25, 2016 at 8:14 AM, Christopher Lalansingh <
clalansingh@gmail.com> wrote:
… Great, thanks very much.
On 12:27AM, Sun, Dec 25, 2016 Syohei YOSHIDA ***@***.***>
wrote:
> Thanks for information. I confirmed this bug is reproduced.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#68 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAk8Lm480XIybFYMUs5rnqUdR9sSXZZvks5rLf7KgaJpZM4LU8kU>
> .
>
|
Released |
syohex
added a commit
that referenced
this pull request
Jan 14, 2017
Changelog diff is: diff --git a/Changes b/Changes index c50ca85..6565eeb 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,11 @@ Revision history for Mouse {{$NEXT}} +v2.4.7 2017-01-14T13:46:04Z + - Workaround for issue #64(#67) + In some case stack is corrupted at more than 23 attributes. + This change may makes a bit slow in that case. + v2.4.6 2017-01-06T06:51:15Z - Fix test for older Perls (#68) - Define macros for older Visual Studio compiler(#66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've discovered that two tests have been failing which can be solved by adding single quotes to barewords. The failed tests are:
With the summary as follows:
After fixing the barewords in my pull request, all tests pass:
Thanks,
Chris