Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS REVIEW: Benchmarks comparison. #51

Closed
1 task
rbeucher opened this issue Feb 3, 2022 · 3 comments
Closed
1 task

JOSS REVIEW: Benchmarks comparison. #51

rbeucher opened this issue Feb 3, 2022 · 3 comments
Assignees
@rafaelmds

Comments

@rbeucher
Copy link

rbeucher commented Feb 3, 2022 •
edited
Loading

  • Please add versions of the codes used for comparison in the Benchmarks... Use the most recent versions when possible...
@rafaelmds rafaelmds self-assigned this Feb 3, 2022
@rafaelmds rafaelmds mentioned this issue Mar 8, 2022
Merged
2 tasks
@rafaelmds
Copy link
Contributor

Results from vanKeken and Crameri benchmarks were obtained using v0.1.4.
We added this information in the documentation.

Merged in #70.

@rbeucher
Copy link
Author

Here I was more thinking of the other codes.

@rafaelmds rafaelmds mentioned this issue Mar 21, 2022
Merged
@rafaelmds
Copy link
Contributor

I interpreted it wrong...

Actually, the data used for comparison was extracted form the paper figure. The paper only mentions Underworld version.

We've added this information in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaelmds rafaelmds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbeucher @rafaelmds