Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass currentPath as input to the function userRepo #15

Closed
arshadkazmi42 opened this issue Oct 26, 2019 · 1 comment · Fixed by #25
Closed

Pass currentPath as input to the function userRepo #15

arshadkazmi42 opened this issue Oct 26, 2019 · 1 comment · Fixed by #25
Labels
first-timers-only Only for first timers good first issue Good for newcomers Hacktoberfest its hacktoberfest help wanted Extra attention is needed

Comments

@arshadkazmi42
Copy link
Member

Let's add currentPath parameter to userRepo function here
https://github.com/gh-conf/gh-conf-parse/blob/master/lib/user-repo.js#L8

As right now it takes current working directory, but we want to support based on input path and if there is no input path then it will use current working directory

@arshadkazmi42 arshadkazmi42 added first-timers-only Only for first timers good first issue Good for newcomers Hacktoberfest its hacktoberfest help wanted Extra attention is needed labels Oct 26, 2019
@arshadkazmi42 arshadkazmi42 mentioned this issue Oct 26, 2019
2 tasks
@maximangetman
Copy link
Contributor

maximangetman commented Oct 26, 2019

@arshadkazmi42 check this PR #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Only for first timers good first issue Good for newcomers Hacktoberfest its hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants