Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models_zoo.py:deepBach has not been updated for Keras 2 #22

Closed
bzamecnik opened this issue Jul 12, 2017 · 1 comment
Closed

models_zoo.py:deepBach has not been updated for Keras 2 #22

bzamecnik opened this issue Jul 12, 2017 · 1 comment

Comments

@bzamecnik
Copy link
Contributor

In b8f6049 and other commits there the model code for upgraded for compatibility with Keras 2. However in this commit some necessary changes are missing, in particular the merge() function was replaced by add() or concatenate() only in the deepbach_skip_connections model, but not in deepBach. This results in the first example command in README to fail.
bzamecnik added a commit to bzamecnik/DeepBach that referenced this issue Jul 12, 2017
@bzamecnik
Ghadjeres#22 Upgrade deepBach model in models_zoo.py to Keras 2 (merg…
a8d39d5 
…e -> concatenate).
@Ghadjeres Ghadjeres mentioned this issue Jul 12, 2017
Closed
@Ghadjeres
Copy link
Owner

You are right. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bzamecnik @Ghadjeres