Rename PtrRep to BoxedRep #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. Do you intend to submit? |
|
Thanks for pinging me. Two weeks for discussion have elapsed. I'd like to submit this to the committee. |
nomeata
added
the
Pending committee review
|
Shepherding that myself, acceptance proposed. /remind me to see if there is consensus in one week. |
|
@nomeata set a reminder for Dec 17th 2019 |
nomeata
changed the title
Merged
|
👋 @nomeata, see if there is consensus . |
nomeata
added
Accepted
sgraf812
referenced
this pull request
Jan 31, 2020
sgraf812
added a commit
to sgraf812/ghc-proposals
that referenced
this pull request
Jan 31, 2020
There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so.
sgraf812
added a commit
to sgraf812/ghc-proposals
that referenced
this pull request
Jan 31, 2020
There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so.
sgraf812
added a commit
to sgraf812/ghc-proposals
that referenced
this pull request
Jan 31, 2020
…typos There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so. I also fixed a couple of typos and renamed some types to clarify.
sgraf812
added a commit
to sgraf812/ghc-proposals
that referenced
this pull request
Jan 31, 2020
…typos There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so. I also fixed a couple of typos and renamed some types to clarify.
sgraf812
added a commit
to sgraf812/ghc-proposals
that referenced
this pull request
Jan 31, 2020
…typos There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so. I also fixed a couple of typos and renamed some types to clarify.
sgraf812
added a commit
to sgraf812/ghc-proposals
that referenced
this pull request
Jan 31, 2020
…typos There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so. I also fixed a couple of typos and renamed some types to clarify.
nomeata
changed the title
nomeata
added
the
Implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion starting with Sebastian's comment in the Pointer Rep proposal. This amends the proposal, renaming
PtrReptoBoxedRep.