Use Lifted and Unlifted in #265 consistently #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggreif care to review? I’ll merge if you approve. |
sgraf812
referenced
this pull request
Jan 31, 2020
sgraf812
force-pushed
the
unlifted-data
branch
from
537c2d9
to
f9996fa
Compare
|
Thanks, fixed. |
RyanGlScott
reviewed
Jan 31, 2020
|
Oh boy, I should probably give it another read and pick up all the typos I can find. |
sgraf812
force-pushed
the
unlifted-data
branch
3 times, most recently
from
25f262b
to
9af828a
Compare
…typos There were a couple of places in ghc-proposals#265 where I used `UnliftedRep`, `LiftedRep` or even `TYPE LiftedRep`, an uncomfortable mixture of assuming ghc-proposals#203/ghc-proposals#301 and not doing so. I also fixed a couple of typos and renamed some types to clarify.
sgraf812
force-pushed
the
unlifted-data
branch
from
9af828a
to
cb98530
Compare
|
Do you think you’ll find more or I should I merge? |
|
I fixed everything immediately obvious, so yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of places in #265 where I used
UnliftedRep,LiftedRepor evenTYPE LiftedRep, an uncomfortable mixture ofassuming #203/#301 and not doing so.