Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createAnswer returns RTCSessionDescription instead of RTCSessionDescriptionInit #3

Closed
eskimor opened this issue Jul 19, 2017 · 1 comment

Comments

@eskimor
Copy link
Contributor

eskimor commented Jul 19, 2017

In jsaddle-dom there are two createAnswer functions one is generated and does return a RTCSessionDescriptionInit, the other is custom and does a conversion to RTCSessionDescription. The custom one is exported. This is unfortunate for two reasons:

  1. the return value of createAnswer is used in setLocalDescription which expects a RTCSessionDescriptionInit.
  2. ghcjs-dom only has the generated one, which returns a RTCSessionDescriptionInit. Thus it seems to be incompatible with jsaddle-dom.

I can file a PR for exporting the generated function and maybe even dropping the custom one if this is the way to go. Am I missing something?

@hamishmack
Copy link
Member

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants