Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDNObsMetadata returning an empty window #17

Closed
ctroupin opened this issue Sep 27, 2018 · 6 comments
Closed

SDNObsMetadata returning an empty window #17

ctroupin opened this issue Sep 27, 2018 · 6 comments

Comments

@ctroupin
Copy link
Member

When running the notebook 09-ODV-data-import.ipynb, the line

SDNObsMetadata(obsid[10])

opens a windows but it only contains this text:
"The resource you are looking for has been removed, had its name changed, or is temporarily unavailable."

Maybe related to a change of URL for SDN?

@ctroupin
Copy link
Member Author

ctroupin commented Oct 4, 2018

Minimum working example:

using DIVAnd
DIVAnd.SDNObsMetadata("681-RNODC_Bottle_106_122")

✔️ 0.6.4
❌ 0.7.0
❌ 1.0.0

and it's because the returned URLs differ:
0.6.4 → http://seadatanet.maris2.nl/v_cdi_v3/print_wfs.asp?popup=yes&edmo=681&identifier=RNODC_Bottle_106_122
1.0.0 → "http://seadatanet.maris2.nl/v_cdi_v3/print_wfs.asp:?popup=yes&edmo=681&identifier=RNODC_Bottle_106_122"

HTTP.URI has a slightly different response, for example:
0.6.4:

julia> HTTP.URI(;query=Dict("popup" => "yes"))  
HTTP.URI("?popup=yes")

1.0.0:

julia> HTTP.URI(;query=Dict("popup" => "yes")) 
HTTP.URI(":?popup=yes")

@Alexander-Barth
Copy link
Member

Thanks Charles.
I reported it here: JuliaWeb/HTTP.jl#323

@Alexander-Barth
Copy link
Member

Fixed now in HTTP.jl.

@ctroupin
Copy link
Member Author

ctroupin commented Oct 5, 2018

Ok let's test and close if it works.

@Alexander-Barth
Copy link
Member

yes, releases in HTTP.jl seem to be on a ~ weekly basis, so it should not take too long to have this fix in a released version.

@ctroupin
Copy link
Member Author

ok now working with 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants