feat(plugins): sync column definitions to user after plugin adds column #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for some extensions/plugins, that is RowDetail, RowMove, RowSelections, are adding extra columns dynamically when the grid is created and are not synced to the user, this PR will help with that but has to be implement differently in each lib wrappers (Angular, Aurelia, ...)
ghiscoding
added
enhancement
requires Universal change/release
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 968 972 +4
Branches 311 311
=========================================
+ Hits 968 972 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
deleted the
feat/update-column-defs-when-plugin-modify-them
branch
ghiscoding
added a commit
that referenced
this pull request
Nov 17, 2022
ghiscoding
added a commit
that referenced
this pull request
Nov 17, 2022
ghiscoding
added a commit
that referenced
this pull request
Nov 17, 2022
) * feat(common): add "targetSelector" to onFilterChanged & Grid State * fix(plugins): rollback PR #881 to fix regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs