Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): sync column definitions to user after plugin adds column #781

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 24, 2022

  • for some extensions/plugins (RowDetail, RowMove, RowSelections) that are adding extra columns dynamically when the grid is created and are not synced to the user's side. This PR will help with that, however it has to be implement differently in each lib wrappers (Angular, Aurelia, ...)
  • this is related to this Angular-Slickgrid issue

- for some extensions/plugins, that is RowDetail, RowMove, RowSelections, are adding extra columns dynamically when the grid is created and are not synced to the user, this PR will help with that but has to be implement differently in each lib wrappers (Angular, Aurelia, ...)
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #781 (a2c5a9d) into master (8ad54b5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #781   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          234       234           
  Lines        16378     16383    +5     
  Branches      5498      5498           
=========================================
+ Hits         16378     16383    +5     
Impacted Files Coverage Δ
...common/src/extensions/slickCheckboxSelectColumn.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/slickRowMoveManager.ts 100.00% <100.00%> (ø)
packages/common/src/services/extension.service.ts 100.00% <100.00%> (ø)
...s/row-detail-view-plugin/src/slickRowDetailView.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding changed the title feat(plugins): sync column definitions to user after add plugin columns feat(plugins): sync column definitions to user after plugin adds column Oct 24, 2022
@ghiscoding ghiscoding merged commit 0755b65 into master Oct 25, 2022
@ghiscoding ghiscoding deleted the feat/update-column-defs-when-plugin-modify-them branch October 25, 2022 01:40
ghiscoding-SE pushed a commit that referenced this pull request Nov 18, 2022
- synching column definitions after plugin (like Row Move col) is causing issue when used with Grid State & Presets since the presets seem out of sync with the ones pushed by the plugin changed event
ghiscoding added a commit that referenced this pull request Nov 18, 2022
)

* fix(plugins): rollback PR #781 to fix regression with Grid Presets
- synching column definitions after plugin (like Row Move col) is causing issue when used with Grid State & Presets since the presets seem out of sync with the ones pushed by the plugin changed event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant