fix: prefer ESM module over CJS & prefer TS loaders #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
May 30, 2023
ghiscoding
commented
- update package.json exports to prefer ESM over CJS which is the same prefs in Slickgrid-Universal and the new multiple-select-vanilla lib
- also remove AMD build since it's not even used, there's no reason to keep it
- also prefer TS loaders instead of Babel loaders
- add missing event prop
- update package.json exports to prefer ESM over CJS which is the same prefs in Slickgrid-Universal and the new multiple-select-vanilla lib - also remove AMD build since it's not even used, there's no reason to keep it - also prefer TS loaders instead of Babel loaders - add missing event prop
…g/slickgrid-react into bugfix/package-exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.