fix(common): Select All checkbox shouldn't disappear w/Dark Mode toggle #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when using Row Selections grid option, the Select All checkbox was disappearing after toggling Dark Mode, that was caused by the fact that calling `grid.setOptions()` is recreating the header columns and the Select All itself is not being recreated - also the same issue happened whenever reordering a column to another position because again it called the grid set columns and that again rerendered all column headers without the Select All - to fix both issue, I added a new `onAfterSetColumns` SlickEvent which we subscribe to inside the SlickCheckboxSelectColumn plugin, and whenever triggered, we reevaluate the Select All which in term recreates it
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
========================================
+ Coverage 99.8% 99.8% +0.1%
========================================
Files 199 199
Lines 21607 21611 +4
Branches 7228 6961 -267
========================================
+ Hits 21543 21547 +4
- Misses 58 64 +6
+ Partials 6 0 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid.setOptions()is recreating the header columns and the Select All itself is not being recreatedonAfterSetColumnsSlickEvent which we subscribe to inside the SlickCheckboxSelectColumn plugin, and whenever triggered, we reevaluate the Select All which in term recreates itbelow are the 2 problems identified that were fixed by this PR