Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OData): wrong operator comparison #1461

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

zewa666
Copy link
Contributor

@zewa666 zewa666 commented Apr 9, 2024

this fixes the wrong operator comparison, causing FieldTypes.date in OData to be always checked with the eq operator, regardless of the users definition

Copy link

stackblitz bot commented Apr 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding
Copy link
Owner

wow what a mistake, good catch. However I do see the exact same issue on the GraphQL Service, would you mind fixing that one too?

@zewa666
Copy link
Contributor Author

zewa666 commented Apr 9, 2024

ups seems its also happening for graphql. Can't validated that with a real sample

EDIT: lol you're too fast :)

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (4c4be44) to head (ab38b9b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1461    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         199     199            
  Lines       21703   21703            
  Branches     7261    7124   -137     
=======================================
  Hits        21639   21639            
  Misses         58      58            
  Partials        6       6            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit abe772b into ghiscoding:master Apr 9, 2024
6 checks passed
@ghiscoding
Copy link
Owner

Thanks again 😉

@ghiscoding ghiscoding changed the title fix: wrong operator comparison fix(OData): wrong operator comparison Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants