Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Header Menu missing columnDef in sub-menu action callback #1572

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 13, 2024

  • the action callback arguments should always include the column definition which it was triggered from, but in the case of sub-menu it was missing because it wasn't propagated properly
  • I encounter this problem with the Header Menu but I'm assuming that it was probably the same for all other Menu plugins

- the `action` callback arguments should always include the column definition which it was triggered from, but in the case of sub-menu it was missing because it wasn't propagated properly
Copy link

stackblitz bot commented Jun 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (c6f1cf3) to head (343831a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1572    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21731   21731            
  Branches     7278    7005   -273     
=======================================
  Hits        21670   21670            
- Misses         55      61     +6     
+ Partials        6       0     -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 55d77d0 into master Jun 13, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/header-menu-missing-coldef branch June 13, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant