fix(plugins): rollback PR #781 to fix regression with Grid Presets #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Nov 18, 2022
ghiscoding
commented
- synching column definitions after plugin (like Row Move col) is causing issue when used with Grid State & Presets since the presets seem out of sync with the ones pushed by the plugin changed event
- synching column definitions after plugin (like Row Move col) is causing issue when used with Grid State & Presets since the presets seem out of sync with the ones pushed by the plugin changed event
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 16366 16363 -3
Branches 5547 5547
=========================================
- Hits 16366 16363 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.