Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $replace #3886

Closed
seia-soto opened this issue Apr 5, 2024 · 1 comment · Fixed by #3897
Closed

Support $replace #3886

seia-soto opened this issue Apr 5, 2024 · 1 comment · Fixed by #3897

Comments

@seia-soto
Copy link
Member

continues #3885

@seia-soto
Copy link
Member Author

Noticed that the overall html filter capability should be improved to support this feature on Ghostery adblocker library. If possible, I want to extend the full html filtering capability. The implementation detail may change heavily based on the direction of this feature. For example, the current html filtering capability is limited at ^script:has-text.

One more thing to think is that our html filtering capability lives at the cosmetic filter. However, $replace modifier should live in the network filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant