-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Tag Manager tracker URLs are blocked #1749
Comments
The "fixes" DNR list has this entry (locally reproduced, so the ID might change):
Where this rule comes from, is not clear yet. |
In the Chrome release, it is this rule (from the "fixes" DNR list):
|
To sum up our findings: That explains why the requests are being shown as trusted in the UI. It should also result in an exclusion rule to allow these requests. However, it is an edge case, because there is a high priority rule on the "unbreak" list:
This rule has Since blocking the request is intentional here - otherwise, it would not be on the unbreak list - the behavior of the adblocker is correct. Arguably, the UI is a bit confusing, since blocked requests are now being shown in a trusted category. On the other hand, it is most likely a rare situation. Maybe the UI could detect such cases, but it is not clear if this extra complexity is justified. (Open question.) But in a nutshell, we have a request that according to TrackerDB is critical and should generally never be blocked. But then, we have a concrete example, where the community decided that it is critical to block it to avoid breakage. Blocking to avoid breakage, is fairly uncommon; normally, it is the opposite (blocking increasing the change of breakage). At least, it is likely that situation like on fandom.com should be rare. |
Description
After a new installation of the add-on, the Google Tag Manager tracker is blocking URLs. It should not.
Steps to Reproduce
Expected results
When the tracker is trusted, URLs must be observed.
When the tracker is blocked, URLs must be blocked.
Versions
The text was updated successfully, but these errors were encountered: