[macOS, UNIX] prefer _SC_PAGESIZE over (partially) deprecated getpagesize() #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1885. getpagesize() is deprecated on macOS, POSIX.1-2001 and possibly other UNIXes. The problem emerged on macOS but getpagesize() is also used in FreeBSD, NetBSD, OpenBSD and AIX, so it makes sense to do this in one place only, similarly to Windows which also provide a psutil_getpagesize() utility. Follow cPython's mmapmodule.c and resourcemodule.c lead and rely on `sysconf(_SC_PAGESIZE)` instead. Leave getpagesize() in place as last resort/attemp for systems where it's not deprecated or they still legitimately rely on it. Also provide a python wrapper so we can test the return value of this C function against Python's stdlib. Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Add a reusable
psutil_getpagesize()utility common to all UNIXes.Related to #1885 (
getpagesize()is deprecated on recent macOS, POSIX.1-2001 and possibly other UNIXes).The problem emerged on macOS but
getpagesize()is also used in FreeBSD, NetBSD, OpenBSD, AIX and sunOS, so it makes sense to do this in one place only, similarly to Windows which also provide apsutil_getpagesize()utility.Follow cPython's
mmapmodule.candresourcemodule.clead and rely onsysconf(_SC_PAGESIZE)instead, but leavegetpagesize()in place as last resort/attempt since on some systems it appears it's not deprecated and/or they legitimately rely on it.Also provide a python wrapper so we can test the return value of this C function against Python's stdlib modules.