Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppVeyor CI #2111

Merged
merged 3 commits into from
Jun 4, 2022
Merged

Fix AppVeyor CI #2111

merged 3 commits into from
Jun 4, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jun 4, 2022

Summary

  • OS: Windows
  • Bug fix: yes
  • Type: scripts, tests, wheels
  • Fixes:

Description

Latest changes on master are failing on AppVeyor.

  1. ensure AppVeyor runs on changes in scripts/internal
  2. fix typo (missing comma) in scripts/internal/winmake.py
  3. disable flake8-bugbear on python < 3.5, it's not supported

Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
@mayeut
Copy link
Contributor Author

mayeut commented Jun 4, 2022

@giampaolo, despite the failing check on issues workflow (which I have no idea how to fix), this is ready for review.

@giampaolo giampaolo merged commit 5ca6870 into giampaolo:master Jun 4, 2022
@giampaolo
Copy link
Owner

Thanks. Merged.

@mayeut mayeut deleted the fix-python27 branch July 14, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants