Refactor win cwd cmdline #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor failure: https://ci.appveyor.com/project/giampaolo/psutil/build/367/job/13xvsqt4e09p6i60 |
Move cwd extraction code from _psutil_windows.c to process_info.c so its closer to psutil_get_cmdline which accesses the process' memory in a similar way.
fbenkstein
force-pushed
the
refactor-win-cwd-cmdline
branch
from
37fde2e
to
6f97c31
Compare
|
Appveyor failure seems unrelated. |
|
Mmmm are you sure? I don't recall ever seeing that error. |
|
The first error was definitely caused by my change. I made an update and now I'm only seing: https://ci.appveyor.com/project/giampaolo/psutil/build/370/job/khsp57dfqvvbomj1#L418 |
fbenkstein
force-pushed
the
refactor-win-cwd-cmdline
branch
from
6f97c31
to
961577a
Compare
added 2 commits
January 26, 2016 10:37
Move the core code of psutil_get_cmdline into a separate function psutil_get_parameters that uses a returncode and an output parameter.
Move core code of psutil_get_cwd into psutil_get_parameters so the common code between psutil_get_cmdline and psutil_get_cwd can be shared.
fbenkstein
force-pushed
the
refactor-win-cwd-cmdline
branch
from
961577a
to
2a47591
Compare
|
Seems ready now. |
|
Can you please update HISTORY.rst describing what has been fixed here? |
|
This isn't actually fixing anything it's just shuffling code around and consolidating. The real fix comes in #739. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed this creates a common function for Process.cwd and Process.cwdline on Windows.