Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory_maps on Windows may be wrong #752

Closed
giampaolo opened this issue Feb 3, 2016 · 1 comment
Closed

memory_maps on Windows may be wrong #752

giampaolo opened this issue Feb 3, 2016 · 1 comment
Labels

Comments

@giampaolo
Copy link
Owner

Right now it returns rss memory only but according to:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa366775(v=vs.85).aspx
...there's a type distinction we are not taking into account.
Each memory region being processed can either be of MEM_IMAGE, MEM_MAPPED or MEM_PRIVATE type. So perhaps the returned tuple should not have any rss field but instead it should have image, mapped and private (which is the most import in order to calculate USS, see also #746).

@giampaolo
Copy link
Owner Author

Apparently all processes I checked are type == MEM_IMAGE so maybe this is correct as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant