[WIP] Code review #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gianarb let me know if there's something wrong in the documentation |
|
It sounds perfect only on question src/App.php docs is work in progress? :) |
|
yes, I'll update the to do list above |
Closed
| * | ||
| * @param \FastRoute\Dispatcher $router Inner router (based on Nikic FastRouter). | ||
| */ | ||
| public function __construct(\FastRoute\Dispatcher $router) |
There was a problem hiding this comment.
fqcn can be moved to use statement
|
@EmanueleMinotto can you submit more PRs? :) step by step.. At the moment we are developing quickly and I prefer this flow 💃 Thanks |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some code reviews (mainly documentation), let me know if everything is ok or not. :)
To Do:
src/App.phpGianArb\Penny