Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC + PHPDoc #28

Merged
merged 10 commits into from
Aug 30, 2015
Merged

OC + PHPDoc #28

merged 10 commits into from
Aug 30, 2015

Conversation

EmanueleMinotto
Copy link
Contributor

Missing src/App.php because requires more time to be studied, to be documented and to apply OC.

@EmanueleMinotto
Copy link
Contributor Author

@gianarb please restart the Scrutinizer check, because this PR is ready
Thanks :)

@gianarb
Copy link
Contributor

gianarb commented Aug 30, 2015

I don't undestand how restart it -.-..

Can you rebase i? :) maybe scrutinizer builds it another time :)

@EmanueleMinotto
Copy link
Contributor Author

Done, let me know if everything is ok

@gianarb
Copy link
Contributor

gianarb commented Aug 30, 2015

Perfect! Thanks

gianarb pushed a commit that referenced this pull request Aug 30, 2015
@gianarb gianarb merged commit 80747fc into pennyphp:master Aug 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants