Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps not showing..... #4

Closed
4evermaat opened this issue Mar 13, 2016 · 9 comments
Closed

Google Maps not showing..... #4

4evermaat opened this issue Mar 13, 2016 · 9 comments

Comments

@4evermaat
Copy link

I noticed that on my local install, the google maps (map) is not showing. I am using the stock template
google maps not showing2

Your webpage example it somewhat works
google maps gravstrap diblas partially works

(google maps loads partially, but no roads).

But in my gravstrap admin install and gravstrap skeleton, the map is grey without loading anything (see first image).

Again, one more example from your own gravstrap homepage: google maps only partially loads.
gravstrap diblas google maps partial

Some more questions: In the plugin shortcode google maps, I do not see ability to enter GPS coordinates, use google maps link, etc.
How does the shortcode know where to place marker? How far to zoom, etc? I don't see where to set the map parameters.

@Hanfrey
Copy link

Hanfrey commented Mar 15, 2016

Hello,

you only have to do two thinks (at least for me this worked then)
Change the setting from the Google Maps Plugin:
From true to false

googlemaps:
built_in_css: false

And add the asset to your base.html.twig from the gravstrap-theme.

{% block bottom %}
    {{ assets.js('bottom') }}
{% endblock %}

Worked fine, the built-in_css makes a proper grey div and the assets.js adds the google maps!

Regarding your last question, its in the yaml part of your page.
Maybe have a look at the Docs from googlemaps plugin, he explained it

@giansi
Copy link
Owner

giansi commented Mar 15, 2016

@4evermaat have you tried @Hanfrey solution? I did and still not works. It does not parse the [GOOGLEMAPS:map] anymore

@Hanfrey
Copy link

Hanfrey commented Mar 15, 2016

I repeated the steps to test if i have something forgot.

  • composer create-project getgrav/grav grav3

  • bin/gpm install gravstrap-theme

  • copy the demo pages in the user/pages folder

  • change the theme in the system.yml and activate the markdown-extra

  • in the user/plugins/googlemaps.yml change built_in_css to false

  • in the /user/themes/gravstrap-theme/templates/partials/base.html.twig add assets in block footer

    {% block footer %}
       {{ assets.js('bottom') }}
      {{ footer }}
      </footer>
      {% endblock %}
    

and its working.

Grav (v1.0.10)

@giansi
Copy link
Owner

giansi commented Mar 17, 2016

Just released v1.0.3 which solves this issue.

@giansi giansi closed this as completed Mar 17, 2016
@4evermaat
Copy link
Author

I updated gravstrap to 1.0.3 and it still shows blue now for me instead of gray.
google maps not showing again 1 0 3

I visited http://gravstrap.diblas.net/ . The map is better (shows marker, google logo, etc, but the full google map still does not load. I visit https://www.google.com/maps/@41.897563,12.518114,11z?hl=en-US directly and the map shows just fine. It is only within gravstrap that is the problem.

Are you guys using different coordinates?
I'm using Google Chrome 49.0.2623.87 m (64 bit) and Firefox 38.x and windows 7 64 bit.


PS: could you find a way to close an issue without closing it permanently? Unless the user is supposed to open a new ticket.

@giansi
Copy link
Owner

giansi commented Mar 18, 2016

Have you removed the [GRAVSTRAP:map] declaration and replaced it with the new shortcode? http://diblas.net/plugins/use-bootstrap-components-as-shortcodes-in-grav-cms/gravstrap-google-map-shortcode#upgrading

I guess you do not completely understand how github works. When I close an issue because I suppose it has been fixed, you can comment it again and if you point something still do not work, I can open the issue again. This means the user is not supposed to open a new ticket, but he should continue with the closed ticket.

@4evermaat
Copy link
Author

This page google maps is now working. Did you update the demo pages in the theme? If you do this, I can copy the updated demo pages and work directly with them.

I'll remember to re-use old tickets for the same issue. Normally the ticket reopens when new comment is opened. But it did not so I was unsure.

@giansi
Copy link
Owner

giansi commented Mar 19, 2016

Yes, I updated the demo pages. You can find them here: https://github.com/giansi/gravstrap-theme-skeleton/tree/master/pages

@4evermaat
Copy link
Author

I can confirm after updating the demo pages, google maps works ok. but your googlemaps shortcode page example has not been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants