warning in mingw build

[GoogleCodeExporter]

What steps will reproduce the problem?

1. compile gtest.cc with mingw

What is the expected output? What do you see instead?

I expect no errors and no warnings.
MinGW reports:
gtest.cc:1929: warning: 'void testing::AddExceptionThrownFailure(DWORD, const 
char*)' defined but not used

Which version of Google Mock are you using? On what operating system?

svn rev 452
Windows 7 32 Bit

Please provide any additional information below.

The "AddExceptionThrownFailure" method is only used for SEH exceptions, so it 
should be enabled with GTEST_HAS_SEH, not GTEST_OS_WINDOWS.

I've attached a patch.

Original issue reported on code.google.com by rjmy...@gmail.com on 5 Aug 2010 at 1:14

• Blocked on: gmock_gen.py does not reproduce "const" for const return type #44

Attachments:

• mingw_warning.patch

[GoogleCodeExporter]

This should be covered with the exception handling changes, requested in issue 
44.

Original comment by vladlosev on 5 Aug 2010 at 6:52

• Changed state: Accepted
• Added labels: Component-Logic, OpSys-Windows, Usability

[GoogleCodeExporter]

The fix belongs in Google Test, not Google Mock. Star the issue 
http://code.google.com/p/googletest/issues/detail?id=44 there for updates.

Original comment by vladlosev on 5 Aug 2010 at 6:55

• Changed state: Invalid