Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes url in wide output #510

Merged
merged 6 commits into from
Jul 9, 2020

Conversation

ubergesundheit
Copy link
Member

This PR adds a new column to kubectl get releases -o wide output.

kubectl get release -o wide
NAME      KUBERNETES VERSION   STATE    AGE                    RELEASE NOTES
v11.2.0   1.16.3               active   2020-03-03T11:12:13Z   https://github.com/giantswarm/releases/tree/master/kvm/v11.2.0

I am unsure why the AGE column is different to output on live installations. I've tested this with a local kind cluster (k8s 1.18.2)

Checklist

  • Consider SIG UX feedback.
  • Update changelog in CHANGELOG.md.
  • If adding a new type, ensure that it is added to the CRD unit tests.

@ubergesundheit ubergesundheit requested a review from a team July 8, 2020 13:56
@ubergesundheit ubergesundheit self-assigned this Jul 8, 2020
crReleaseNotesURLAnnotation = "giantswarm.io/release-notes"
kindRelease = "Release"
releaseDocumentationLink = "https://docs.giantswarm.io/reference/cp-k8s-api/releases.release.giantswarm.io/"
releaseNotesLink = "https://github.com/giantswarm/releases/tree/master/kvm/v11.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the default should be an empty string or https://github.com/giantswarm/releases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just link to the repo as well :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just so that we're on the same page: Once I change the value here, I also need to change it in config/crd/v1/release.giantswarm.io_releases.yaml to satisfy the tests.

Is the value here a default value for the release CR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. We create release CRs with helm+kustomize instead of operators so this is unlikely to come up in the near future anyways (i.e. this code won't be executed anywhere except in the test).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I'll change this now.

Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit - looking nice otherwise 🚀

crReleaseNotesURLAnnotation = "giantswarm.io/release-notes"
kindRelease = "Release"
releaseDocumentationLink = "https://docs.giantswarm.io/reference/cp-k8s-api/releases.release.giantswarm.io/"
releaseNotesLink = "https://github.com/giantswarm/releases/tree/master/kvm/v11.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just link to the repo as well :)

@ubergesundheit ubergesundheit merged commit 428873e into master Jul 9, 2020
@ubergesundheit ubergesundheit deleted the release-notes-url-in-wide-output branch July 9, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants