Separated awstpr and clustertpr #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhlfr
force-pushed
the
nhlfr/separated-awstpr-and-clustertpr
branch
from
5b1fe0c
to
b62d833
Compare
nhlfr
changed the title
|
This is the smaller PR I was talking about. Let's put #22 on hold until that one gets merged. |
xh3b4sd
reviewed
Mar 6, 2017
glide.yaml
Outdated
| version: 3d98b40a2bc399a6a20f3b19c634d56d99a69e81 | ||
| version: 99da9c8f8583749d0fef89d14b3cfa420e13ebc1 | ||
| - package: github.com/giantswarm/clustertpr | ||
| version: 16f7b5230a6850c1b7b62bad4f6002607f8ad3c2 |
There was a problem hiding this comment.
When awstpr is pinned there should be no reason to pin the cluster TPR itself. This repo should be pinned inside the awstpr repo.
| @@ -144,7 +142,6 @@ func main() { | |||
|
|
|||
| daemonCommand.PersistentFlags().StringVar(&Flags.Aws.AccessKey.ID, "aws.accesskey.id", "", "ID of the AWS access key") | |||
| daemonCommand.PersistentFlags().StringVar(&Flags.Aws.AccessKey.Secret, "aws.accesskey.secret", "", "Secret of the AWS access key") | |||
| daemonCommand.PersistentFlags().StringVar(&Flags.Aws.Region, "aws.region", "", "Region in EC2 service") | |||
There was a problem hiding this comment.
I feel like I miss something. Why do we remove the AWS region now?
There was a problem hiding this comment.
As @iaguis said.
Also, we moved the client creation inside the code of "create" service.
nhlfr
force-pushed
the
nhlfr/separated-awstpr-and-clustertpr
branch
from
b62d833
to
a422a54
Compare
xh3b4sd
approved these changes
Mar 6, 2017
nhlfr
force-pushed
the
nhlfr/separated-awstpr-and-clustertpr
branch
from
a422a54
to
d4c32d9
Compare
pipo02mix
pushed a commit
that referenced
this pull request
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24