Adds VirtualNetwork settings #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocotton
reviewed
Sep 7, 2017
| package azure | ||
|
|
||
| type VirtualNetwork struct { | ||
| CIDR string `json:"cidr" yaml:"cidr"` |
There was a problem hiding this comment.
Could it be possible to update the json and yaml tags to match the ones used in the ARM templates?
I can also update my own PR to match your tags without any issues :)
There was a problem hiding this comment.
We need to use this format because Kubernetes uses it for serialising and deserialising the TPOs.
I like having the ARM templates matching for consistency. So if you're OK to change that would be good. But if there are naming conventions for the ARM templates maybe we should follow those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/azure-operator/issues/6
This PR adds the VirtualNetwork settings so they can be used in the Network Setup ARM template.