-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix containerd configuration for local registry caches #178
Conversation
CHANGELOG.md
Outdated
|
||
### Changed | ||
|
||
- Move `.internal.localRegistryCache` to `global.localRegistryCache` to publicly expose the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be moved to $.Values.global.components.containerd.localRegistryCache
($.Values.global.components.containerd
already exists).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here: b517710
b517710
to
f39d30a
Compare
f39d30a
to
32df71a
Compare
Co-authored-by: Marian Steinbach <marian@giantswarm.io>
Co-authored-by: Marian Steinbach <marian@giantswarm.io>
Co-authored-by: Marian Steinbach <marian@giantswarm.io>
Co-authored-by: Marian Steinbach <marian@giantswarm.io>
Co-authored-by: Marian Steinbach <marian@giantswarm.io>
@uvegla Is this still ongoing? |
@Gacko Yes, still working on it. There are a bunch of things we need to test with Zot still. So far what was tested is the caching of GS images (with a WC cache; WC nodes connecting to MC cache). There are a few more scenarios like secondary customer caches for their private images tested in both scenarios. I would wait for the result of those to see if the |
No hurry, please. I was mostly asking because people are opening PRs in the cluster chart repositories for testing purposes as they need a tarball in the catalogs built by CI from time to time and forget about them. |
Yep, I do the same, testing forwards here: giantswarm/cluster-aws#620 |
There were differences in the rendered Helm template, please check! Output
|
What does this PR do?
Towards: https://github.com/giantswarm/giantswarm/issues/30596
Fix broken containerd config that was introduced in #152, and move new Helm values to existing
.global.components.containerd
.What is the effect of this change to users?
How does it look like?
(Please add anything that represents the change visually. Screenshots, output, logs, ...)
Any background context you can provide?
(Please link public issues or summarize if not public.)
What is needed from the reviewers?
Do the docs need to be updated?
Should this change be mentioned in the release notes?