GS 2 [WIP] #4
GS 2 [WIP] #4
Conversation
| retChan := make(chan string) | ||
| m.stopUnit(name, retChan) | ||
|
|
||
| jobReply := <-retChan |
There was a problem hiding this comment.
do we want to time this and a log.Info beforehand?
There was a problem hiding this comment.
nop. its a queue_append operation, the time is meaningless.
There was a problem hiding this comment.
Then where is the block happening? I would assume that stopUnit() is quick because it does stuff in a goroutine / async and this channel is written to, when the stop finished. So the read here is blocking / slow. So time should be meaning full.
There was a problem hiding this comment.
jobReply := <-retChan
the block happens here. this call only returns after systemd has the stop job enqueued. a stop job being enqueued means that systemd will stop it, it doesnt block until it is stopped.
That feature is part of something bigger and unrelated.
…les are used (in memory) for multiple jobs)
|
Is this the version we currently use? I have the feeling we miss some commits here. |
|
this is the version we are using and there are no commits missing. |
Use ffjon instead of the Go json library
|
ping @zeisss Should we close this PR ? |
|
@hectorj2f I created this PR as a proxy for @htr as he forgot it. I have no insight into the actual content, sorry. I cannot judge this. |
No description provided.