Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new tagging for AWS #48

Merged
merged 1 commit into from Mar 16, 2018
Merged

Use new tagging for AWS #48

merged 1 commit into from Mar 16, 2018

Conversation

r7vme
Copy link
Contributor

@r7vme r7vme commented Mar 15, 2018

New tags:

  • giantswarm.io/installation=CLUSTER_NAME
  • kubernetes.io/cluster/CLUSTER_NAME=owned

Instead of:

  • Environment=CLUSTER_NAME
  • KubernetesCluster=CLUSTER_NAME

Terraform does not support interpolation for tag name that's why such ugly constructions are used. See bug hashicorp/terraform#14516

New tags:
- giantswarm.io/installation=CLUSTER_NAME
- kubernetes.io/cluster/ginger=owned

Instead of:
- Environment=CLUSTER_NAME
- KubernetesCluster=CLUSTER_NAME
@r7vme r7vme requested review from rossf7, corest and calvix March 15, 2018 22:37
Environment = "${var.cluster_name}"
KubernetesCluster = "${var.cluster_name}"
}
tags = "${merge(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using merge is nice

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really like the new tags.

@r7vme r7vme merged commit 7dcfe16 into master Mar 16, 2018
@r7vme r7vme deleted the retagging branch March 16, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants