This repository has been archived by the owner on May 7, 2024. It is now read-only.
add --silence-http-endpoint-warning flag #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adrian Barsan <mnlk123@yahoo.com>
|
What was the impact of this change regarding UX? Did the output of authentication related errors or log messages change in any way? |
|
All warnings and errors from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/giantswarm#12975
Requires giantswarm/gscliauth#25
This PR adds a
--silence-http-endpoint-warningsflag which disablesWarning: endpoint URL uses an insecure protocolmessages printed when using gsctl with a http endpoint.