Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for node pools with zero nodes #1971

Merged
merged 4 commits into from Nov 19, 2020
Merged

Allow for node pools with zero nodes #1971

merged 4 commits into from Nov 19, 2020

Conversation

paurosello
Copy link
Contributor

IMPORTANT: The changelog for the next release is generated automatically, based on pull requests merged to master. In order to properly categorize the changes made, you should allocate a proper label to your pull request:

  • Introducing a new feature

    • kind/feature
  • Changing existing functionality

    • kind/change
    • kind/ux-enhancement
  • Soon-to-be removed features

    • kind/deprecation
  • Removing features

    • kind/removal
  • Fixing bugs

    • kind/bug
  • Fixing vulnerabilities

    • kind/security

Excluded from changelog

  • dependencies (Updating dependencies)
  • kind/dev-change (Changing development commands, file structure, etc.)
  • kind/refactor (Improving the implementation of a specific part of the codebase, without changing its functionality)

@paurosello paurosello added the kind/change Changing existing functionality label Nov 13, 2020
@paurosello paurosello requested a review from a team November 13, 2020 10:43
@paurosello
Copy link
Contributor Author

Do i need to put Changelog somewhere? not sure about the release process here

@paurosello
Copy link
Contributor Author

Related to giantswarm/roadmap#234

@marians
Copy link
Member

marians commented Nov 13, 2020

@paurosello Here the title of the PR gets added to the next happa release. Suggestion: Allow for node pools with zero nodes

@paurosello paurosello changed the title Set min to 0 on nodepools Allow for node pools with zero nodes Nov 13, 2020
@paurosello
Copy link
Contributor Author

Cool, changed it

@paurosello
Copy link
Contributor Author

Towards giantswarm/roadmap#234

@paurosello paurosello merged commit ce3ae3f into master Nov 19, 2020
@paurosello paurosello deleted the nodepoolminzero branch November 19, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/change Changing existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants