Allow installing app multiple times if clusterSingleton restriction is not set on AppCatalogEntry
#3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when determining whether an app can be installed in the selected cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#1130.
Previously, we implemented the feature to display the installation status of an app for a selected cluster. However, we didn't take into account the
clusterSingletonrestriction on the app catalog entry when determining installation status. This blocked users from installing an app multiple times for the same workload cluster, even when it does not have theclusterSingletonrestriction.This PR fixes this bug by only disabling the app installation button if this restriction is set on the app catalog entry. Otherwise, the installation button is still actionable.
When the app is installed in a selected cluster, and its app catalog entry has the
clusterSingletonrestriction, we display an appropriate message and disable selecting the cluster from the cluster picker form:When the app is installed in a selected cluster, and its app catalog entry does not have the
clusterSingletonrestriction, we display an appropriate message, but the button is clickable, and users can select the cluster from the cluster picker form: