Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store nodepols inside items object #795

Merged
merged 2 commits into from Oct 10, 2019
Merged

Store nodepols inside items object #795

merged 2 commits into from Oct 10, 2019

Conversation

ograu
Copy link
Contributor

@ograu ograu commented Oct 10, 2019 •
edited

Solved a problem with a cluster not having node pools by moving node pools object inside nodePools.itemsobject, as all other entities in store.

@ograu ograu requested a review from a team October 10, 2019 09:49
marians
marians reviewed Oct 10, 2019
View reviewed changes
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a stake in the implementation details. Sorry ;-)

@ograu
Copy link
Contributor Author

ograu commented Oct 10, 2019

ok... then I suppose I will have to merge it without approval

@ograu ograu merged commit 8a69b91 into master Oct 10, 2019
@ograu ograu deleted the fix-nodepools-404 branch October 10, 2019 15:17
@ograu ograu self-assigned this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marians marians marians left review comments

Assignees

@ograu ograu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ograu @marians