Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default-apps app template generation #1065

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

bavarianbidi
Copy link
Contributor

@bavarianbidi bavarianbidi commented May 15, 2023

What does this PR do?

(Please set a descriptive PR title. Use this space for additional explanations.)

What is the effect of this change to users?

--- .vscode/generated-manifest-current.yaml	2023-05-15 15:54:05.392431214 +0200
+++ .vscode/generated-manifest-new.yaml	2023-05-15 15:59:43.863036035 +0200
@@ -62,14 +62,15 @@
 metadata:
   labels:
     app-operator.giantswarm.io/version: 0.0.0
+    giantswarm.io/cluster: jrp45
   name: jrp45-default-apps
   namespace: org-multi-project
 spec:
   catalog: cluster
   config:
     configMap:
-      name: ""
-      namespace: ""
+      name: jrp45-cluster-values
+      namespace: org-multi-project
     secret:
       name: ""
       namespace: ""

What does it look like?

(Please add anything that represents the change visually. Screenshots, output, logs, ...)

Any background context you can provide?

Towards the kube-proxy replacement powered by Cilium

What is needed from the reviewers?

Without the auto-generated -cluster-values configmap, the mandatory baseDomain value doesn't get propagated to the cilium config which is required to run in kube-proxy-less mode.

Do the docs need to be updated?

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated

Is this a breaking change?

(Breaking changes are, for example, removal of commnds/flags or substantial changes in the meaning of a flag. If yes, please add the breaking-change label to the PR.)

Copy link
Contributor

@primeroz primeroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can you add an example run of kubectl gs template ?

@bavarianbidi
Copy link
Contributor Author

LGTM. can you add an example run of kubectl gs template ?

it's already documented in our public docs:
https://docs.giantswarm.io/getting-started/capz-cluster-creation/

@bavarianbidi bavarianbidi marked this pull request as ready for review May 17, 2023 05:15
@bavarianbidi bavarianbidi requested a review from a team May 17, 2023 05:15
@bavarianbidi bavarianbidi merged commit f3e4350 into main May 17, 2023
@bavarianbidi bavarianbidi deleted the fix_broken_capi_template branch May 17, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants