fix default-apps app template generation #1065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Please set a descriptive PR title. Use this space for additional explanations.)
What is the effect of this change to users?
What does it look like?
(Please add anything that represents the change visually. Screenshots, output, logs, ...)
Any background context you can provide?
Towards the
kube-proxy
replacement powered by CiliumWhat is needed from the reviewers?
Without the auto-generated
-cluster-values
configmap, the mandatorybaseDomain
value doesn't get propagated to the cilium config which is required to run inkube-proxy
-less mode.Do the docs need to be updated?
Should this change be mentioned in the release notes?
Is this a breaking change?
(Breaking changes are, for example, removal of commnds/flags or substantial changes in the meaning of a flag. If yes, please add the
breaking-change
label to the PR.)